Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaper: undefined method `delete_suffix' for nil:NilClass #585

Closed
yaoyi opened this issue Mar 19, 2021 · 1 comment · Fixed by #586
Closed

Reaper: undefined method `delete_suffix' for nil:NilClass #585

yaoyi opened this issue Mar 19, 2021 · 1 comment · Fixed by #586
Assignees
@mhenrixon

Comments

@yaoyi
Copy link

yaoyi commented Mar 19, 2021 •
edited

in ruby reaper:

def match?(key_one, key_two)
   key_one.delete_suffix(RUN_SUFFIX) == key_two.delete_suffix(RUN_SUFFIX)
end

the key_two payload[LOCK_DIGEST] could be nil, which causes the undefined method delete_suffix for nil:NilClass
@mhenrixon mhenrixon self-assigned this Mar 19, 2021
mhenrixon added a commit that referenced this issue Mar 19, 2021
@mhenrixon
Consider match only with both values present
2e39dcd 
Close #585
@mhenrixon mhenrixon mentioned this issue Mar 19, 2021
Merged
mhenrixon added a commit that referenced this issue Mar 19, 2021
@mhenrixon
Consider a match only when both values present (#586)
3e80a0c 
* Update changelog

* Bump dependency for brpoplpush-redis_script

* Fix building on push

* Consider match only with both values present

Close #585
@mhenrixon
Copy link
Owner

Fixed in v7.0.6 sorry about that, I'll see if I can remember to write a test case for the when I receive a job that isn't unique later but for right now it should fix your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhenrixon mhenrixon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider a match only when both values present mhenrixon/sidekiq-unique-jobs
2 participants
@mhenrixon @yaoyi