Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock_info set to true but no lock info showing up in web ui #589

Closed
jakesorce opened this issue Apr 6, 2021 · 16 comments · Fixed by #599 or #645
Closed

lock_info set to true but no lock info showing up in web ui #589

jakesorce opened this issue Apr 6, 2021 · 16 comments · Fixed by #599 or #645
Assignees

Comments

@jakesorce
Copy link

Describe the bug
Screen Shot 2021-04-06 at 1 22 03 PM

SidekiqUniqueJobs.configure do |config|
  config.debug_lua = true # true for debugging
  config.lock_info = true # true for debugging
  config.max_history = 1000 # keeps n number of changelog entries
  config.reaper = :ruby # also :lua but that will lock while cleaning
  config.reaper_count = 1000 # Reap maximum this many orphaned locks
  config.reaper_interval = 10 # Reap every 10 seconds
  config.reaper_timeout = 5 # Give the reaper 5 seonds to finish
end

Expected behavior
Expected behavior is to have the lock_info show up in the UI so we can debug jobs

Current behavior
Lock info does not show up in the UI.

To use it turn the following setting on: SidekiqUniqueJobs.config.lock_info = true- I get this message when I look at the locked job

Worker class

Screen Shot 2021-04-06 at 1 23 20 PM

Additional context
N/A

@mhenrixon
Copy link
Owner

You have spotted a bug @jakesorce! I vaguely remembering being perplexed about this, will look into it immediately.

@mhenrixon mhenrixon self-assigned this Apr 8, 2021
@jakesorce
Copy link
Author

Thank you 🙏🏼

@Laykou
Copy link

Laykou commented Apr 26, 2021

We observed the same issue with the latest (as of today) version of this gem + sidekiq.

mhenrixon added a commit that referenced this issue Apr 26, 2021
mhenrixon added a commit that referenced this issue Apr 26, 2021
* Fix recording lock_info

Close #589

* Mandatory code smell commit
@mhenrixon
Copy link
Owner

@pdkproitf
Copy link

This does not work on version 7.1.5
In rails console, the configuration show true

Screenshot 2021-08-13 at 1 29 06 PM

In the worker:

sidekiq_options queue: :edenred, lock: :until_executed, retry: RETRY_INTERVALS.length, lock_info: true

Screenshot 2021-08-13 at 1 32 36 PM

@bdarcet
Copy link

bdarcet commented Sep 13, 2021

Hey @mhenrixon ! We're facing the same problem on the latest gem release. Anything we should do ? Reopen an issue ?

Versions:
sidekiq (6.2.2)
sidekiq-unique-jobs (7.1.5)

@crondaemon
Copy link
Contributor

Same here with sidekiq 6.2.1 and sidekiq-unique-jobs 7.1.5.

@mhenrixon mhenrixon reopened this Sep 23, 2021
@mhenrixon
Copy link
Owner

Alright, reopening the issue. Looks like I need some more tests somewhere.

@marciojg
Copy link

Same issue here.

# config/initializers/sidekiq.rb

SidekiqUniqueJobs.config.lock_info = true

Versions:
sidekiq (6.2.2)
sidekiq-unique-jobs (7.1.6)

@abbbe
Copy link

abbbe commented Oct 6, 2021

Facing the same issue

sidekiq (6.2.2)
sidekiq-unique-jobs (7.1.7)

mhenrixon added a commit that referenced this issue Oct 8, 2021
mhenrixon added a commit that referenced this issue Oct 8, 2021
* Prevent too eager cleanup of lock info

Close #589
Close #602

* Mandatory rubocop commit
@mhenrixon
Copy link
Owner

Released as v7.1.8

@mhenrixon
Copy link
Owner

@blanchma
Copy link

Still happening in v7.1.8, sidekiq v6.3.1

@selivandex
Copy link

Still happening in v7.1.25, sidekiq 6.4.2

@mhenrixon
Copy link
Owner

I will have another look at this.

@mhenrixon
Copy link
Owner

I have test coverage for this saying it should be working and when I try it out locally it also works as expected:

CleanShot 2022-07-25 at 12 46 50@2x

@selivandex @blanchma can you provide some more information about your setup? Can't seem to replicate the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants