Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq Pro Sharded Web UI Error > 7.0.8 #605

Closed
navied opened this issue May 14, 2021 · 6 comments · Fixed by #606
Closed

Sidekiq Pro Sharded Web UI Error > 7.0.8 #605

navied opened this issue May 14, 2021 · 6 comments · Fixed by #606

Comments

@navied
Copy link

navied commented May 14, 2021

Describe the bug
When using Sidekiq Pro's Web UI Sharded mode, it breaks retrying, and deleting jobs due to this part of the code:

return Object.const_get(str) unless str.include?("::")

It tries to look for a job that does not exist on the instance that is running the web UI and instead ends up with a NameError.

Expected behavior

For the sidekiq web ui not to break

@mhenrixon
Copy link
Owner

Can't really help there since I don't have a sidekiq pro subscription.

If someone would cover that for me I'd love to better support Sidekiq pro.

Hard to debug without the code.

@mhenrixon
Copy link
Owner

Perhaps you could provide the stack trace of the entire thing (relevant unique jobs lines only).

It seems like this is just a weird edge case that could be a problem regardless of Sidekiq Pro or not.

@navied
Copy link
Author

navied commented May 15, 2021

I can definitely test any patches if you have any ideas where the issue might be! Here is the stack trace:

image

@mhenrixon
Copy link
Owner

Ah ok, I was confused about the PRO part.

This has nothing to do with Sidekiq Pro. It is a situation for when the worker doesn't exist on where the code is running.

The place it crashes needs to be handled better.

I'll write a failing test for this later.

@mhenrixon
Copy link
Owner

@navied could you verify if the linked PR fixes the issue for you? I suspect you are gathering multiple sidekiq processes under a single Sidekiq::Web?

@navied
Copy link
Author

navied commented May 16, 2021

@mhenrixon just gave it a try, looks all good on my side now! Thanks for the quick fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants