mock_redis and the mess

[phuongnd08]

We are running into an issue that the test pass on local machine but failed on CircleCI.
Upon close inspection, I can see that between tests the mock_redis instance that SidekiqUniqueJobs is pointing to need to be cleared so that the pre-condition of the spec can be guaranteed.

Though, with the presence of mock_redis, I think it makes the gem complicated and doesn't worth the hassle. Per my opinion, sidekiq-unique-jobs should just use what ever the redis sidekiq is using, even during test mode. This lead to more predictable behavior of the tests cross environments.

[mhenrixon]

See here for the background #25 if you can solve that problem AND removing mock_redis feel free to open a new pull request. Specifically watch my answer #25 (comment)

[phuongnd08]

Do you think we really need to ensure uniqueness during inline testing?

[mhenrixon]

I know I want to at least and others did more than me. If I need to ensure that I only bill a customer once every 30 days I must be able to test this properly or customers might end up getting billed infinite number in a month. I guess turning sidekiq testing off would do this but someone suggested to be able to run sort of integration test without having redis installed which I thought was a valid point.