fix for #168. Handle the NOSCRIPT by sending the script again

[otzy007]

Run EVAL again if NOSCRIPT error happens. This will fix #168
Based on the documentation from http://redis.io/commands/EVAL#bandwidth-and-evalsha:
The client library implementation can always optimistically send EVALSHA under the hood even when the client actually calls EVAL, in the hope the script was already seen by the server. If the NOSCRIPT error is returned EVAL will be used instead.

[mhenrixon]

Thank you!

Could you fix the errors? Not sure if this is your fault but I am reluctant to merge anything that doesn't pass the tests and style violation. Would love to get this released! 😄

[otzy007]

I've fixed the rubocop's method is too long offense.
There's one more from the master branch

spec/support/sidekiq_meta.rb:20:9: C: Avoid modifier if after another conditional.
    end if version && operator
        ^^

What do we do with it?

[mhenrixon]

Lets just ignore that one for now. Personally really like those types of if statements so just ignore that error until I consider how to handle it properly.

[otzy007]

hmm. Ok.

this

  unless Sidekiq::VERSION.send(operator, version)
      skip('Skipped due to version check (requirement was that sidekiq version is ' \
           "#{operator} #{version}; was #{Sidekiq::VERSION})")
    end if version && operator

could be changed to just this?

   if version && operator && Sidekiq::VERSION.send(operator, version).nil?
      skip('Skipped due to version check (requirement was that sidekiq version is ' \
           "#{operator} #{version}; was #{Sidekiq::VERSION})")
    end

Tests are passing with it

[mhenrixon]

Sounds good to me!

[otzy007]

Ok. I'll open later another PR with the unless change
This one is ready to be merged 😀