Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reap as many orphans as advertised #403

Merged
merged 6 commits into from
Jun 4, 2019
Merged

Reap as many orphans as advertised #403

merged 6 commits into from
Jun 4, 2019

Conversation

mhenrixon
Copy link
Owner

@mhenrixon mhenrixon commented Jun 3, 2019 •
edited

This PR contains two fixes mostly related to the Reaper

  1. Fix race condition where script finished already. When calling SCRIPT KILL it is possible that from the time we received the initial error onto now that the script could have finished. Just retry in that case!
  2. Reap as many orphans as advertised, the reaper wouldn't reap as many orphans as configured.

@mhenrixon mhenrixon added this to the V7.0 milestone Jun 3, 2019
@mhenrixon mhenrixon self-assigned this Jun 3, 2019
@mhenrixon mhenrixon changed the title Fix race condition where script finished already Fix that the reaper didn't reap as many orphans as advertised Jun 3, 2019
@mhenrixon mhenrixon changed the title Fix that the reaper didn't reap as many orphans as advertised Reap as many orphans as advertised Jun 3, 2019
@mhenrixon mhenrixon merged commit cbe0b5e into master Jun 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the ensure-reaper_count branch June 4, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhenrixon mhenrixon

Labels
bug v7.x
Projects
None yet
Milestone
V7.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mhenrixon