Fix sidekiq develop #426
Merged
Fix sidekiq develop #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
added a commit
that referenced
this pull request
Oct 1, 2019
* Mandatory rubocop commit * Allow failures on sidekiq.develop # Conflicts: # lib/sidekiq_unique_jobs/version_check.rb # spec/sidekiq_unique_jobs/key_spec.rb
mhenrixon
added a commit
that referenced
this pull request
Oct 3, 2019
* Copy working setup from master * Remove unused configuration (rspec-retry) * Fix broken specs * Make specs more reliable * Fix sidekiq develop (#426) * Mandatory rubocop commit * Allow failures on sidekiq.develop # Conflicts: # lib/sidekiq_unique_jobs/version_check.rb # spec/sidekiq_unique_jobs/key_spec.rb * Mandatory rubocop commit * Fix tests * Update ruby versions Takes care of some security breaches * Prevent JRuby from using Pry * Use pry for jruby * Use fake irb too for the sake of jfuckingruby * Make testing of console_class.start work * Mandatory rubocop commit * Another mandatory rubocop commit * Include .simplecov with rubocop * Cleanup after experiments * Unfortunately truffleruby is sooooo slooooow * Update rubocop 💣 * Fix compatibility with Sidekiq 6.0. logger * Fix .yardopts * Improve performance by avoiding the block arg
mhenrixon
added a commit
that referenced
this pull request
Oct 5, 2019
* Copy working setup from master * Remove unused configuration (rspec-retry) * Fix broken specs * Make specs more reliable * Fix sidekiq develop (#426) * Mandatory rubocop commit * Allow failures on sidekiq.develop # Conflicts: # lib/sidekiq_unique_jobs/version_check.rb # spec/sidekiq_unique_jobs/key_spec.rb * Mandatory rubocop commit * Fix tests * Update ruby versions Takes care of some security breaches * Prevent JRuby from using Pry * Use pry for jruby * Use fake irb too for the sake of jfuckingruby * Make testing of console_class.start work * Mandatory rubocop commit * Another mandatory rubocop commit * Include .simplecov with rubocop * Cleanup after experiments * Unfortunately truffleruby is sooooo slooooow * Update rubocop 💣 * Fix compatibility with Sidekiq 6.0. logger * Fix .yardopts * Improve performance by avoiding the block arg * Close #419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.