Deep stringify worker options to account for hash in on_conflict #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all a massive thank you for both PRs! Secondly, would it be possible to get a test that makes this fail unless the deep stringify keys are present? I'm asking because obviously there was missing test coverage to begin with and I'd like to improve that :) I can also add it after merging if you are in a rush, would be great to have this fixed once and for all. In all honesty, I didn't quite understand the problem initially. |
jasonbekolay
commented
May 19, 2020
mhenrixon
reviewed
May 19, 2020
mhenrixon
reviewed
May 19, 2020
mhenrixon
reviewed
May 19, 2020
| "lock" => :until_and_while_executing, | ||
| "on_conflict" => { | ||
| "client" => :log, | ||
| "server" => :reschedule, |
There was a problem hiding this comment.
Yup! This test should be good enough!
jasonbekolay
force-pushed
the
master
branch
2 times, most recently
from
abeb1c1
to
50d0f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.