Stringify on_conflict hash in Job prepare method #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
approved these changes
May 21, 2020
|
Released as v7.0.0.beta18! |
|
Thanks for the quick attention and release! Currently running in production and it looks good so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately my PR yesterday did not resolve the issue. While we did correct
worker_options, it turns out that in the client it doesn't follow that code path when there's a conflict. My apologies for missing the mark, I didn't test thoroughly enough.I was able to determine the root cause of the issue. The
job_hashis stringified bySidekiq.default_worker_options, and it's just a shallow stringify. That means theon_conflicthash still has symbols for keys by the time it gets tofind_strategy.The approach I took to resolve is to stringify the hash in
Job#prepare. I'm happy to change or tweak the approach on your advice.Thanks for your time recently and the quick release! Hopefully this change fixes this issue for good.