Fix RubyReaper active? #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhenrixon Can you pease take a look? |
mhenrixon
approved these changes
Oct 26, 2020
|
This was released as v7.0.0.beta25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537
This PR should fix an issue where orphaned digests are not being considered orphaned if there are any active jobs in Redis.
I've verified the broken behaviour by adding tests for when other jobs are active that do not share the same unique digest - this test does not pass on
master.I'm not super familiar with the internals of Redis, but this should at the very least get the ball rolling in the right direction. Please point out anything that looks wrong.