Fixing reschedule when using a non default queue #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bigzed this was a complete oversight by me! Of course, the job should be put on the queue it belongs to. Could you rebase/merge the main branch and I'll get this released with the next version! Oh, and also, the rubocop issue would be great to address as well. |
I noticed, that when I use the `on_conflict` strategy `:reschedule` with a job, that has a `until_and_while_executing` lock and is configured to run on a specific queue,(e.g. `no_default`). `:reschedule` tries to enqueue it into the `default` queue. The commit lets `:reschedule` honour the queue.
bigzed
force-pushed
the
fixing-reschedule
branch
from
5a74a03
to
0174dad
Compare
|
Hello @mhenrixon, the branch is rebased to |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job uses a non default queue in it's
sidekiq_options, theon_conflictstrategy still enqueues the job into thedefaultqueue even though, the queue information is available initem.The MR fixes this by calling
set(queue: item['queue'].to_sym)beforeperform_inin reschedule. It assumes thatitemalways contains queue.