Fix Sidekiq::Worker.clear_all override not being applied #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This in build on top of #713 because I didn't want to deal with merge conflicts 😄 I'll rebase this branch if you accept the first PR. |
mhenrixon
approved these changes
Jun 2, 2022
dsander
force-pushed
the
fixing-reschedule-and-testing-clear-all
branch
from
336e5a2
to
b6bd1df
Compare
|
Could you try and fix the broken tests and such so that we can get this merged @dsander? |
Since the method is defined as a singleton the testing override needs to be prepended to the singleton class.
dsander
force-pushed
the
fixing-reschedule-and-testing-clear-all
branch
from
a10299e
to
819a869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the method is defined as a singleton the testing override needs to
be prepended to the singleton class.