Fix(until_and_while_executing): Improve timeouts slightly #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgunther
reviewed
Jul 27, 2022
| @@ -3,12 +3,14 @@ | |||
| RSpec.describe "SidekiqUniqueJobs::Lock::UntilAndWhileExecuting" do | |||
| before do | |||
| digests.delete_by_pattern("*") | |||
| toxic_redis_url = ENV["CI"] ? "toxiproxy:21212" : "localhost:21212" | |||
There was a problem hiding this comment.
I suspect you'll also need the following for CI to properly point to the toxiproxy daemon container/service:
Toxiproxy.host = 'http://toxiproxy:8474' if ENV["CI"]I'd imagine this'll resolve the current Failed to open TCP connection to 127.0.0.1:8474 errors in CI.
There was a problem hiding this comment.
Failed to open TCP connection to toxiproxy:8474 (getaddrinfo: Temporary failure in name resolution)
🤷♂️
Well I got it working locally so I'll skip this spec for CI for now.
mhenrixon
changed the title
This was referenced Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.