Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak changelog for 8.0.9 #836

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

Earlopain
Copy link
Contributor

Makes an explicit note that this was a non-issue. Dependabot uses this changelog file to provide context snippets in PR descriptions. My hope is that even though there has been no new release this will be picked up anyways.

Alternativly, the changelog entry could be removed entirely.

Would need backporting to 7.1 I think

Copy link
Owner

@mhenrixon mhenrixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the changelog is generated based on git history. I should maintain it manually because I am unhappy with the result. I could generate a temporary one and maintain the real one manually.

I appreciate you bringing this to my attention. I'll make sure to copy this to the release notes on the GitHub release as well.

@mhenrixon
Copy link
Owner

I won't merge yet, want to prevent your addition from magically disappearing like my commit the other day.

@mhenrixon
Copy link
Owner

Added it to the Github release for both gem versions.

@mhenrixon mhenrixon merged commit 6b81b77 into mhenrixon:main Feb 16, 2024
18 checks passed
@Earlopain
Copy link
Contributor Author

won't merge yet

Merged 3 minutes later. Thanks. Again, not sure if tools will actually pick this up or if they pull from specific releases instead.

Fetching the latest one would make sense, to make amends like this. Let's see ehat happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants