Skip to content

Commit

Permalink
Tear down network when restarting containers
Browse files Browse the repository at this point in the history
This makes restart a bit slower for root containers, but it does
make it more consistent with `podman stop` and `podman start` on
a container. Importantly, `podman restart` will now recreate
firewall rules if they were somehow purged.

Fixes containers#5051

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
  • Loading branch information
mheon committed Feb 2, 2020
1 parent 4699d5e commit 6d487c7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions libpod/container_internal.go
Expand Up @@ -1254,6 +1254,12 @@ func (c *Container) restartWithTimeout(ctx context.Context, timeout uint) (err e
}
}
}
// Ensure we tear down the container network so it will be
// recreated - otherwise, behavior of restart differs from stop
// and start
if err := c.cleanupNetwork(); err != nil {
return err
}
}
defer func() {
if err != nil {
Expand Down

0 comments on commit 6d487c7

Please sign in to comment.