Add connection timeouts to broker api calls #1113

mher · Jun 20, 2021 · d4ea1dc · d4ea1dc
1 parent 3560865
commit d4ea1dc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/flower/utils/broker.py b/flower/utils/broker.py
@@ -73,6 +73,7 @@ def queues(self, names):
         try:
             response = yield http_client.fetch(
                 url, auth_username=username, auth_password=password,
+                connect_timeout=1.0, request_timeout=2.0,
                 validate_cert=False)
         except (socket.error, httpclient.HTTPError) as e:
             logger.error("RabbitMQ management API call failed: %s", e)

diff --git a/flower/views/broker.py b/flower/views/broker.py
@@ -27,7 +27,7 @@ def get(self):
             broker_use_ssl = self.capp.conf.BROKER_USE_SSL
 
         try:
-            broker = Broker(app.capp.connection().as_uri(include_password=True),
+            broker = Broker(app.capp.connection(connect_timeout=1.0).as_uri(include_password=True),
                             http_api=http_api, broker_options=broker_options, broker_use_ssl=broker_use_ssl)
         except NotImplementedError:
             raise web.HTTPError(