Encode worker and task names in URL (#1204)

This addresses a bug where worker or task names that contain characters that should be URL encoded cannot be navigated to in the UI.
mher · May 21, 2022 · f41b072 · f41b072
1 parent 95bd80b
commit f41b072
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/flower/static/js/flower.js b/flower/static/js/flower.js
@@ -468,7 +468,7 @@ var flower = (function () {
                 data: 'hostname',
                 type: 'natural',
                 render: function (data, type, full, meta) {
-                    return '<a href="' + url_prefix() + '/worker/' + data + '">' + data + '</a>';
+                    return '<a href="' + url_prefix() + '/worker/' + encodeURIComponent(data) + '">' + data + '</a>';
                 }
             }, {
                 targets: 1,
@@ -559,7 +559,7 @@ var flower = (function () {
                 visible: isColumnVisible('uuid'),
                 orderable: false,
                 render: function (data, type, full, meta) {
-                    return '<a href="' + url_prefix() + '/task/' + data + '">' + data + '</a>';
+                    return '<a href="' + url_prefix() + '/task/' + encodeURIComponent(data) + '">' + data + '</a>';
                 }
             }, {
                 targets: 2,
@@ -623,7 +623,7 @@ var flower = (function () {
                 data: 'worker',
                 visible: isColumnVisible('worker'),
                 render: function (data, type, full, meta) {
-                    return '<a href="' + url_prefix() + '/worker/' + data + '">' + data + '</a>';
+                    return '<a href="' + url_prefix() + '/worker/' + encodeURIComponent(data) + '">' + data + '</a>';
                 }
             }, {
                 targets: 10,