You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There is no favicon defined in the <head> block so when flower is served with a url_prefix, the favicon does not display properly. Also, because the navbar is a Tornado Template rather than an {% import, it has its own namespacing and does not inherit the static_url behavior, which leaves the icon pointing to /favicon.ico
To Reproduce
Steps to reproduce the behavior (favicon):
look in <head> block and see no explicit mention of favicon.ico This becomes an issue when flower is served from a url_prefix as browsers will default to /favicon.ico
Steps to reproduce the behavior (navbar):
start flower with a url_prefix
see that the icon in the navbar does not point to /$urlprefix/favicon.ico but instead to /favicon.ico
Expected behavior favicon.ico is explicitly located in the <head> block and the navbar image works when using url_prefix
Screenshots
The text was updated successfully, but these errors were encountered:
Describe the bug
There is no favicon defined in the
<head>
block so when flower is served with aurl_prefix
, the favicon does not display properly. Also, because the navbar is a TornadoTemplate
rather than an{% import
, it has its own namespacing and does not inherit thestatic_url
behavior, which leaves the icon pointing to/favicon.ico
To Reproduce
Steps to reproduce the behavior (favicon):
<head>
block and see no explicit mention offavicon.ico
This becomes an issue when flower is served from a url_prefix as browsers will default to/favicon.ico
Steps to reproduce the behavior (navbar):
url_prefix
/$urlprefix/favicon.ico
but instead to/favicon.ico
Expected behavior
favicon.ico
is explicitly located in the<head>
block and the navbar image works when usingurl_prefix
Screenshots
![Screenshot 2023-11-20 at 4 29 34 PM](https://private-user-images.githubusercontent.com/5065964/284397833-c460eec0-42b5-4879-9f63-20231c6f7a9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMTA0OTYsIm5iZiI6MTcyNDMxMDE5NiwicGF0aCI6Ii81MDY1OTY0LzI4NDM5NzgzMy1jNDYwZWVjMC00MmI1LTQ4NzktOWY2My0yMDIzMWM2ZjdhOWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDcwMzE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MWFmOTEyNjAxZGZkNDg0YmYxYmNlZjQ5NWNmNGFjMWI4NTc3MGY1OGQ5M2FmMGEwNzBjZjllNmQ1OGUwMWE4MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.lYGv1ktkxwPNK6rGMmzWYzOz1kp7tbmHhGvv4Maot4s)
![Screenshot 2023-11-20 at 4 29 43 PM](https://private-user-images.githubusercontent.com/5065964/284397836-f7d65903-d3d4-46bb-9d40-965626e0f32e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMTA0OTYsIm5iZiI6MTcyNDMxMDE5NiwicGF0aCI6Ii81MDY1OTY0LzI4NDM5NzgzNi1mN2Q2NTkwMy1kM2Q0LTQ2YmItOWQ0MC05NjU2MjZlMGYzMmUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDcwMzE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTU0NDQ0Y2UxNDJmZDgwODE0YzVkYjIwODEyOWM1NTk0Yjc2NTliZTkyNWZhOTBiYTE4N2M4MTg4ZWRlZmM5OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ZR4p8NbeSQSOYe0DAkMleEAt9FWjDY49YuDZOh4CodM)
![Screenshot 2023-11-20 at 4 30 02 PM](https://private-user-images.githubusercontent.com/5065964/284397838-dd726c77-b0c0-454b-b451-e6b024fe4ede.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMTA0OTYsIm5iZiI6MTcyNDMxMDE5NiwicGF0aCI6Ii81MDY1OTY0LzI4NDM5NzgzOC1kZDcyNmM3Ny1iMGMwLTQ1NGItYjQ1MS1lNmIwMjRmZTRlZGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDcwMzE2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWVlMzJiMmJkYzIxODI4NDkyZmQ4YWM1ZDRlMTA1MGI4OWJjYTIwMTJmZTcxNWIwMzRjOWJmMDljYmQzYzQ5YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rJf4m_cejfCF4n0r3zCxKRH9_cq7W--wuuW_yetvFNs)
The text was updated successfully, but these errors were encountered: