Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon not assigned and icon in navbar does not work #1338

Closed
joesolly opened this issue Nov 20, 2023 · 3 comments
Closed

Favicon not assigned and icon in navbar does not work #1338

joesolly opened this issue Nov 20, 2023 · 3 comments
Labels
bug

Comments

@joesolly
Copy link

Describe the bug
There is no favicon defined in the <head> block so when flower is served with a url_prefix, the favicon does not display properly. Also, because the navbar is a Tornado Template rather than an {% import, it has its own namespacing and does not inherit the static_url behavior, which leaves the icon pointing to /favicon.ico

To Reproduce
Steps to reproduce the behavior (favicon):

  1. look in <head> block and see no explicit mention of favicon.ico This becomes an issue when flower is served from a url_prefix as browsers will default to /favicon.ico

Steps to reproduce the behavior (navbar):

  1. start flower with a url_prefix
  2. see that the icon in the navbar does not point to /$urlprefix/favicon.ico but instead to /favicon.ico

Expected behavior
favicon.ico is explicitly located in the <head> block and the navbar image works when using url_prefix

Screenshots
Screenshot 2023-11-20 at 4 29 34 PM
Screenshot 2023-11-20 at 4 29 43 PM
Screenshot 2023-11-20 at 4 30 02 PM
@joesolly joesolly added the bug label Nov 20, 2023
@joesolly joesolly mentioned this issue Nov 20, 2023
Closed
@onyx-flame
Copy link
Contributor

This issue should be fixed in v2.0.1
Which version are you using?

@joesolly
Copy link
Author

joesolly commented Dec 5, 2023

This issue should be fixed in v2.0.1 Which version are you using?

I'm still on 2.0.0, thanks for the heads up

@joesolly
Copy link
Author

joesolly commented Dec 5, 2023

I tested on 2.0.1 and it's working

@joesolly joesolly closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joesolly @onyx-flame