Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct hyperlinks with custom url_prefix applied #1297

Merged
merged 6 commits into from
Jun 24, 2023
Merged

Correct hyperlinks with custom url_prefix applied #1297

merged 6 commits into from
Jun 24, 2023

Conversation

onyx-flame
Copy link
Contributor

@onyx-flame onyx-flame commented Jun 22, 2023

Templates and scripts had invalid links during running behind proxy with non-empty url_prefix.
It resulted in missing Celery icon in the navbar and invalid task links located in the workers table footer.
Now <a> tag of favicon takes into account prepended url_prefix and JS-generated links have a missing url_prefix()

Before:
image

After:
image

@onyx-flame onyx-flame marked this pull request as ready for review June 22, 2023 20:28
@onyx-flame onyx-flame changed the title Correct hyperlinks with custom url_prefix is applied Correct hyperlinks with custom url_prefix applied Jun 22, 2023
@onyx-flame
Copy link
Contributor Author

onyx-flame commented Jun 23, 2023

I've updated stale minimal nginx configuration sample from examples folder.
Also now documentation describes the case with Flower placed under custom nginx location.

@mher
Copy link
Owner

mher commented Jun 24, 2023

Thanks for the pull request! Can you add some unit tests?

@onyx-flame
Copy link
Contributor Author

There already was a test class which covers this case, so I've updated it a bit and simplified tests run command

@mher mher merged commit 6ffefa1 into mher:master Jun 24, 2023
9 checks passed
@onyx-flame onyx-flame deleted the bugfix/url-prefixed-links branch June 24, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants