build: add build system configuration to pyproject.toml
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
pyproject.tomlfile including the build system configuration as recommended by setuptools's docs.The current build process uses
setup.py installwhich is deprecated in newer versions ofpip. See the discussion in pypa/pip#8559 for more information. One of the recommended fixes to that is specifying the build system in apyproject.tomlfile.I tested this by running
pip install .with and without thepyproject.tomlconfiguration. By installing this project without the pyproject file, I was able to reproduce #42. By installing this project with the pyproject file, the warning vanished.Fixes #42.