Fix caching of chromedriver in start_chrome(...)

mherrmann · Aug 3, 2023 · c4d7998 · c4d7998
1 parent 821b16c
commit c4d7998
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/docs/conf.py b/docs/conf.py
@@ -12,7 +12,7 @@
 author = 'Michael Herrmann'
 
 # Also update ../setup.py when you change this:
-release = '3.2.4'
+release = '3.2.5'
 
 
 # -- General configuration ---------------------------------------------------

diff --git a/helium/_impl/chromedriver.py b/helium/_impl/chromedriver.py
@@ -1,6 +1,14 @@
 from webdriver_manager.chrome import ChromeDriverManager
 from webdriver_manager.core.driver_cache import DriverCacheManager
 
+import webdriver_manager
+
+# Work around a bug in webdriver_manager:
+if webdriver_manager.__version__ == '4.0.0':
+	class DriverCacheManager(DriverCacheManager):
+		def __get_metadata_key(self, driver):
+			super().__get_metadata_key(driver)
+			return self._metadata_key
 
 def install_matching_chromedriver(cache_dir=None):
 	manager = ChromeDriverManager(cache_manager=DriverCacheManager(cache_dir))

diff --git a/requirements/base.txt b/requirements/base.txt
@@ -5,4 +5,4 @@ selenium==3.141.0
 # Selenium 3 is incompatible with urllib3 >= 2:
 urllib3<2
 
-webdriver-manager==4.0.0
+webdriver-manager>=4.0.0
diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 setup(
 	name = 'helium',
 	# Also update docs/conf.py when you change this:
-	version = '3.2.4',
+	version = '3.2.5',
 	author = 'Michael Herrmann',
 	author_email = 'michael+removethisifyouarehuman@herrmann.io',
 	description = 'Lighter browser automation based on Selenium.',
@@ -16,7 +16,7 @@
 		'selenium==3.141.0',
 		# Selenium 3 is incompatible with urllib3 >= 2:
 		'urllib3<2',
-		'webdriver-manager==4.0.0'
+		'webdriver-manager>=4.0.0'
 	],
 	package_data = {
 		'helium._impl': ['webdrivers/**/*']