jasmine.Clock broken in node.js

[lsegal]

Seems related to this google groups thread

Running this example from pivotal.github.com/jasmine fails:

describe("Manually ticking the Jasmine Mock Clock", function() {
  var timerCallback;

  beforeEach(function() {
    timerCallback = jasmine.createSpy('timerCallback');
    jasmine.Clock.useMock();
  });

  it("causes a timeout to be called synchronously", function() {
    setTimeout(function() {
      timerCallback();
    }, 100);

    expect(timerCallback).not.toHaveBeenCalled();

    jasmine.Clock.tick(101);

    expect(timerCallback).toHaveBeenCalled();
  });

  it("causes an interval to be called synchronously", function() {
    setInterval(function() {
      timerCallback();
    }, 100);

    expect(timerCallback).not.toHaveBeenCalled();

    jasmine.Clock.tick(101);
    expect(timerCallback.callCount).toEqual(1);

    jasmine.Clock.tick(50);
    expect(timerCallback.callCount).toEqual(1);

    jasmine.Clock.tick(50);
    expect(timerCallback.callCount).toEqual(2);
  });
});

[V1c70r]

I have the same problem.

[nfriedly]

I'm hitting this too. runs() and waitFor() work, but in the end I just tweaked my JS to use a utility method that calls setTimeout() and then had jasmine spy on that utility and call a fake that just fires the callback immediately.

[lsegal]

Indeed, I worked around this by re-assigning the setTimeout global to a mock that increments a global counter for "timeWaited". We can assert the time delays by checking this variable. Looks something like:

var oldSetTimeout, timeWaited;
beforeEach(function() {
  oldSetTimeout = setTimeout;
  timeWaited = 0;
  setTimeout = function(callback, timeout) {
    timeWaited += timeout;
    callback(); // FIXME handle callback passed as String
  };
});

afterEach(function() { setTimeout = oldSetTimeout; });

[pathsny]

this is in my spec helper. it solves the problem jasmine.getGlobal = function() { return GLOBAL; }

jasmine.getGlobal().setTimeout = function(funcToCall, millis) {
  if (jasmine.Clock.installed.setTimeout.apply) {
    return jasmine.Clock.installed.setTimeout.apply(this, arguments);
  } else {
    return jasmine.Clock.installed.setTimeout(funcToCall, millis);
  }
};

and so on. All 4 lines from jasmine.js

[mainiak]

Temporarily solved with SinonJS fake timers which could be used separately.

[tebriel]

I've got this fixed in a new beta, I'll push it up here after 1.1.1 is released.

[tebriel]

Ready for publish. Currently in 1.2.0 branch.

[nfriedly]

Whoot! Drinks on me if we ever meetup somewhere :)

[tebriel]

Hah. I'll hold you to that! Have you verified? It works in my tests,knowing it works somewhere else would be awesome.

[nfriedly]

No, but I'll try and get it in early this week and let you know.

[tebriel]

Awesome, thanks!

[nfriedly]

Just updated and it works perfectly! I removed all the runs() and waitsFor()s from my code and now all of my tests combined finish in just under 2 seconds!

[tebriel]

Fantastic! Glad to hear it.

[mainiak]

Thank you for the fix - but I am still having issues. See https://gist.github.com/mainiak/4355050

Line below will fail. Seems like clearInterval isn't working.

git clone https://gist.github.com/4355050.git && cd 4355050 && patch -i nodejs.patch && jasmine-node --coffee --verbose .

[vvondra]

I am still having the issue above form @mainiak