check null to solve crash #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhiew
reviewed
Dec 27, 2021
There was a problem hiding this comment.
Hey @YOEL311, thanks for investigating and putting up a PR!
I'll keep the guard statement which might protect against the NPE. 👍
This might stop crashes, but I have a feeling it will not fix the root issue and some of your users may not be able to load pdfs.
I took a look at the original repo and think that the issue is probably due to this
I'll implement the fix of moving thread creation from the constructor into onAttachedToWindow.
I am also a bit hesitant to integrate any of the gradle changes so I will likely leave those out for now.
mhiew
added a commit
that referenced
this pull request
Dec 27, 2021
- the thread creation and recycling was not being handled symmetrically - this fix is based off of these two PR: DImuthuUpe#824 and #2
|
I am going to close this for now. Hopefully the change here helps address the issue you were facing. |
|
Thanks, |
AhmerAfzal1
added a commit
to AhmerAfzal1/AhmerPdfium
that referenced
this pull request
Feb 14, 2022
Fix a potential NPE due to out of sync render thread management [Pull Request](DImuthuUpe/AndroidPdfViewer#824) Update the sample app configuration so that it can compile [Pull Request](mhiew/AndroidPdfViewer#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get crash
Android OS: 9<
Fatal Exception: java.lang.NullPointerException
Attempt to invoke virtual method 'boolean android.os.HandlerThread.isAlive()' on a null object reference
com.github.barteksc.pdfviewer.PDFView.loadComplete (PDFView.java:756)
com.github.barteksc.pdfviewer.DecodingAsyncTask.onPostExecute (DecodingAsyncTask.java:80)
com.github.barteksc.pdfviewer.DecodingAsyncTask.onPostExecute (DecodingAsyncTask.java:27)
android.os.AsyncTask.finish (AsyncTask.java:755)
android.os.AsyncTask.access$900 (AsyncTask.java:192)
android.os.AsyncTask$InternalHandler.handleMessage (AsyncTask.java:772)
android.os.Handler.dispatchMessage (Handler.java:107)
android.os.Looper.loop (Looper.java:237)
android.app.ActivityThread.main (ActivityThread.java:8167)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:496)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1100)