Build only necessary static libs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EXP files are export tables for DLLs, unrelated to the static libraries being built here.
TBBle
force-pushed
the
static-libs-only
branch
from
4c88df5
to
58cac07
Compare
This was referenced Feb 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lxml is only interested in the _a.lib versions of the libraries, so this both avoids building other things, and and reduces packaging complexity.
It cut build-times on AppVeyor down from 3 minutes to 2 minutes.
I've tested these against the lxml build by pointing the download URLs to AppVeyor and running:
python -u setup.py bdist_wheel --static-deps --run-teststo confirm no regressions.