-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple files in new nvim instance don't open in tabs when using --remote-tab-*
#44
Comments
Yup, the current fallback is simple: it merely starts a new local process: In a perfect world we would start a new nvim process, with the given servername, and control that one remotely with all the options that were given to nvr. Not sure if that's as easy as it sounds. We have to start the process in the background, continue running nvr which accesses the new nvim's API, then foreground the process in the end. Not sure how to do that with Python. I look into it. |
How about forking a delayed |
If the given instance is not found, we fork nvr. The parent process gets replaced by a new nvim instance. The child waits for one second and then tries attaching to the newly started nvim instance. Advantage: All options passed to nvr are now correctly handled even by new nvim instances that were started by nvr. References #44
Please pull the latest commits and see if it works as expected. |
It passes all my local tests, so I'm closing this. Please reopen this if there are any issues for you. And thank you for bringing this up! 🎉 |
pacman -Q neovim-remote-git
:When spawning a new
nvim
instance (e.g. in case--servername
is invalid) to open multiple files in tabs (via the--remote-tab*
options), the buffers open, but not in tabs. Only the first one is shown in the window, the others have to be navigated with:next
&:prev
.The text was updated successfully, but these errors were encountered: