Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different command for nvr #48

Closed
ysolis opened this issue Jul 21, 2017 · 12 comments
Closed

Different command for nvr #48

ysolis opened this issue Jul 21, 2017 · 12 comments

Comments

@ysolis
Copy link

ysolis commented Jul 21, 2017

I had configured neovim in my machine (Ubuntu 16.04 LTS) with neovim-gnome-terminal wrapper, to have a 'gui' for me.

now, I see that neovim-remote call directly 'nvim' (line 78 in nvim/nvim.py file).

can be possible to setup this command with an ENV var for example ? In my case I have 'neovim' command in my path (that call neovim-gnome-terminal wrapper' and I change in this line to 'neovim' command and works.

this can be an ENV variable that if is setup can be used and if is not, we use nvim command

the same thing can be for silent mode, that can be default if an ENV var is setup too.

@mhinz
Copy link
Owner

mhinz commented Jul 22, 2017

I totally see the need for customizing the command used by nvr. Using an environment variable for it also makes sense in this case.

Adding env var support just for silent mode seems a bit overkill to me though. :-)

So, how does support for $NVR_CMD sound?

@ysolis
Copy link
Author

ysolis commented Jul 24, 2017

sounds good to me :)

P.D. silent mode, can we see this in another issue ?

mhinz added a commit that referenced this issue Jul 25, 2017
@mhinz
Copy link
Owner

mhinz commented Jul 25, 2017

$NVR_CMD should work now!

P.D. silent mode, can we see this in another issue ?

Why do you need that as env variable if -s already exists?

@ysolis
Copy link
Author

ysolis commented Jul 26, 2017

check this, when no neovim is running, this message appears in silent mode (and launch neovim and create /tmp/mvimsocket )

image

@mhinz
Copy link
Owner

mhinz commented Jul 26, 2017

Oh, ah. Yes.. nvr foo is nvr --remote foo and the --remote flags don't take -s into account yet. All other options do. I'll fix that.

But $NVR_CMD is working as expected?

mhinz added a commit that referenced this issue Jul 26, 2017
@mhinz
Copy link
Owner

mhinz commented Jul 26, 2017

The above commit should make -s work as expected, even for the --remote options.

mhinz added a commit that referenced this issue Jul 26, 2017
@ysolis
Copy link
Author

ysolis commented Jul 27, 2017

-s works, but now neovim-remote launch a new nvim console every time, saying that can't connect to /tmp/nvimsocket ... $NVR_CMD set to nvim and neovim-gnome-wrapper, same scenario :(

@mhinz
Copy link
Owner

mhinz commented Jul 27, 2017

Does /tmp/nvimsocket exist and there is a nvim instance running where :echo v:servername is /tmp/nvimsocket?

@ysolis
Copy link
Author

ysolis commented Jul 27, 2017

my mistake, I quit neovim and after this /tmp/nvimscket remains, so I delete the socket, restart with nvr -s and it works!

@mhinz
Copy link
Owner

mhinz commented Jul 27, 2017

Oh, usually nvim should remove the socket on its own, except when it got killed.

Anyway, I guess this can be closed now?

@mhinz mhinz added the solved? label Jul 27, 2017
@ysolis
Copy link
Author

ysolis commented Jul 28, 2017

yes :) close this one ... thanks!

P.D. one last thing, add the $NVR_CMD info in the README.rst file.

@mhinz
Copy link
Owner

mhinz commented Jul 28, 2017

add the $NVR_CMD info in the README.rst file

Done.

Thanks for bringing up all these issues!

@mhinz mhinz closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants