Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors not working in iTerm2 with Solarized Dark #24

Closed
jondkinney opened this issue Apr 17, 2013 · 8 comments
Closed

Colors not working in iTerm2 with Solarized Dark #24

jondkinney opened this issue Apr 17, 2013 · 8 comments

Comments

@jondkinney
Copy link

Hi there,

I'm seeing about using this over vim-gitgutter as I hope it doesn't slow down console vim as much. However, the default color scheme is gray for add and changed, it is properly red for delete. When I pulled open vim-gitgutter and looked at the highlighting they're using (which does work by the way) it appears they are using the same ctermfg variables that you are (by default) and I tried manually specifying them too but to no avail. See screenshot below:

Thanks,
Jon

Screen Shot 2013-04-17 at 10 01 15 AM

The above screenshot is the default vim-signify setup, with no customizations to colors.

Screen Shot 2013-04-17 at 10 04 56 AM

The above screenshot is vim-gitgutter "working". The colors are funny because of what you have to do to setup Solarized Dark in iTerm with the color pallet, but I'm used to those colors now at least, and they're better than straight gray.

Let me know if you have any suggestions! Thanks again.

@mhinz
Copy link
Owner

mhinz commented Apr 17, 2013

Hey!

I double-checked with someone on IRC. He uses the exact same settings and experiences the same issue. But it worked for him when he used a iTerm2 theme other than dark-solarized.

Sadly I have no access to OSX. But I'll dig into it.

Thanks for reporting!

@jondkinney
Copy link
Author

Thanks for taking a look! Please let me know if there is anything I can do to help.

@mhinz mhinz closed this as completed in c495565 Apr 18, 2013
@mhinz
Copy link
Owner

mhinz commented Apr 18, 2013

@Raimondi figured it out for us. 👍

Whatever this iTerm2 theme is doing, it works if you use a normal weight font.

let g:signify_sign_weight = 'none'

EDIT: I just learned from @Osse that you're probably using the font Monaco which doesn't feature a bold typeface.

@mhinz
Copy link
Owner

mhinz commented Apr 18, 2013

On another note.. I just looked at the screenshots again.. in case you want the signs to use the same background color than your line number column:

let g:signify_sign_color_inherit_from_linenr = 1

@jondkinney
Copy link
Author

Thanks @mhinz! I can get the colors to show up on initial load now, nice. However, if I save the file they go back to gray. Odd. Would you like me to file a separate issue for that faulty save behavior?

Indeed, I am using Monaco. Actually, Monaco for Powerline (with the added glyphs).

@Raimondi
Copy link

Try with 'NONE' in capitals:

     let signify_sign_weight = 'NONE'

That's what I have and I don't see that issue with saving.

@jondkinney
Copy link
Author

Yea, it actually works fine now. It just wasn't working in my .vimrc (which is version controlled), but in my normal projects it works great. Thanks!

@tridevgurung
Copy link

Check you contrast level. Make it to minimum. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants