Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting lost on lines with signs #31

Closed
ipkiss42 opened this issue Jun 22, 2013 · 7 comments
Closed

Syntax highlighting lost on lines with signs #31

ipkiss42 opened this issue Jun 22, 2013 · 7 comments

Comments

@ipkiss42
Copy link

Hi,

I would like to configure Sy so that signs appear in the left margin, but without any change to the normal syntax highlighting (the one corresponding to the filetype).

With "let g:signify_line_highlight = 0", the diff highlighting is not visible, but the corresponding lines do not have the normal syntax highlighting either. So in a file with many changes, there is almost no syntax highlighting left, which is quite annoying.

@mhinz
Copy link
Owner

mhinz commented Jun 22, 2013

Hey.

That should be the normal behaviour (since line highlighting is disabled by default).

  1. What colorscheme are you using and how do you set it?
  2. What happens when you press <leader>gh twice? (I guess there's still no syntax highlighting then.)

@ipkiss42
Copy link
Author

This is indeed the default behaviour (it was not clear from the help: you should perhaps indicate the default value of each option).

You are right, it comes from my colorscheme. The colorscheme I use was generated with CSApproxSnapshot (from the CSApprox plugin), to have nice colors in my terminal Vim.
What could I do to fix the issue (I don't mind generating the colorscheme again if needed, but I do want my nice colors)?

@mhinz
Copy link
Owner

mhinz commented Jun 22, 2013

Right, I'll add the default values to the doc.

I know that CSApprox generates terminal colors from gui colorschemes. What does CSApproxSnapshot do? Does it create a colorscheme file from these colors? If so, please paste it somewhere.

@ipkiss42
Copy link
Author

You can read more about CSApproxSnapshot here: https://github.com/godlygeek/csapprox/blob/master/doc/CSApprox.txt

Here is the original colorscheme: http://pastebin.com/FzFThFed
And ihere is the version generated with CSApproxSnapshot: http://pastebin.com/7hSuDvjY

The issue is only there with the generated colorscheme, not with the source one.

@mhinz
Copy link
Owner

mhinz commented Jun 23, 2013

Ehm, the generated colorscheme uses that line:

CSAHi NONE term=NONE cterm=NONE ctermbg=bg ctermfg=fg gui=NONE guibg=bg guifg=fg

The command CSAHi isn't doing that much. You can basically replace it by the highlight command.

I'm not sure why godlygeek is redefining NONE, but syntax highlighting for lines with signs works if you remove them.

@ipkiss42
Copy link
Author

Thanks for investigating this!
I create issue godlygeek/csapprox#11 to get to the bottom of the problem, so I'm closing this issue.

@mhinz
Copy link
Owner

mhinz commented Jun 24, 2013

Hah, I'm glad it works for you now. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants