Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte package migration #118

Merged
merged 13 commits into from Mar 16, 2023
Merged

Svelte package migration #118

merged 13 commits into from Mar 16, 2023

Conversation

mhkeller
Copy link
Owner

This updates the npm run package process to use the new svelte-package library. It defines exports and typesVersions.

@mhkeller
Copy link
Owner Author

Tagging some Layer Cake typescript users to see if this package.json is set up correctly. If you could take a look and see if this is the easiest way to set up the exports and types, I would appreciate it: @abalmos, @techniq, @allezxandre

I am using the typesVersion option as described here but perhaps a better way to do it is to add documentation saying people need to:

set the moduleResolution option in their tsconfig/jsconfig.json to bundler (available since TypeScript 5, the best and recommended option in the future), node16 or nodenext.

Let me know if you have thoughts on what is currently easiest for typescript users.

@mhkeller mhkeller mentioned this pull request Mar 12, 2023
@allezxandre
Copy link

Sorry, I can't be of much help here, I've always used the default settings with TypeScript code, so I wouldn't know how integrating your own type definitions would work 😕

@mhkeller mhkeller merged commit ddc7671 into main Mar 16, 2023
@mhkeller mhkeller deleted the svelte-package-migration branch March 16, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants