Fix Svelte Check warnings #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 'Cannot find module 'fs' or its corresponding type declarations.'
Fixes errors like 'Cannot find module '../../_data/fruitOrdinal.csv' or its corresponding type declarations.'
Error message was: 'Argument of type 'number[]' is not assignable to parameter of type 'number'. '
Error was 'Type 'readonly string[]' is not assignable to type 'Function | number[] | string[] | [min: number, max: number]'.' Note that ForceDirectedGraph is currently commented out in `examples.js`
Error was: 'Object literal may only specify known properties, and '"text-outline"' does not exist in type 'HTMLProps<"text", SVGAttributes<any>>'.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to better understand what's going on in #141 I tried running
npm run check.Not sure if that's the way to go as appeasing all type checking can be hard but it did help to catch some typos/missing braces. There still remain a bunch of errors but I wanted to start a PR to get your thoughts.
I disabled checking on
marked-it.jsto remove a lot of errors for now.