Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add transform components #95

Merged
merged 46 commits into from Dec 25, 2022
Merged

Draft: Add transform components #95

merged 46 commits into from Dec 25, 2022

Conversation

mhkeller
Copy link
Owner

@mhkeller mhkeller commented Jul 31, 2022

Per #93

@mhkeller mhkeller marked this pull request as draft July 31, 2022 02:15
@mhkeller mhkeller changed the title Add transform components Draft: Add transform components Jul 31, 2022
@mhkeller
Copy link
Owner Author

mhkeller commented Nov 4, 2022

This is mostly done. I need to harmonize some of the examples so that they use this and then also some don't use them so people can see it both ways. It may be most helpful to have a new section on the website, too, similar to the component gallery.

@mhkeller
Copy link
Owner Author

Not sure if these are really all that helpful...

@mhkeller
Copy link
Owner Author

I kept the Facet component but converted the others to simple helper functions

@mhkeller
Copy link
Owner Author

mhkeller commented Dec 25, 2022

Actually the facet one doesn't make for a good general use component, even if it is a fun idea. it belongs in user land and not in the library.

@mhkeller
Copy link
Owner Author

Here's a fun example though for posterity: https://svelte.dev/repl/f71eebb8f0014bbe93739937a122bbe4?version=3.55.0

@mhkeller mhkeller marked this pull request as ready for review December 25, 2022 04:26
@mhkeller mhkeller merged commit 6fa1258 into main Dec 25, 2022
@mhkeller mhkeller deleted the transforms branch December 25, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant