Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOCK/UNLOCK and other Webdav method support #38

Open
arichiardi opened this issue Aug 17, 2023 · 5 comments
Open

LOCK/UNLOCK and other Webdav method support #38

arichiardi opened this issue Aug 17, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@arichiardi
Copy link

Hi there, really liking caddy and learning a bunch, while trying to contribute a bit! To the forum.

I was wondering if you see this plugin evolving so that it can support class 1 or class 2 WebDAV.

My current need does not involve anything fancy but it would be nice to stay with caddy if the need for a lock, for instance, arises.

Thanks for your effort!

@ArcCal
Copy link

ArcCal commented Aug 17, 2023

Sometimes, LOCK/UNLOCK can be real nightmare

@mholt
Copy link
Owner

mholt commented Aug 17, 2023

I don't actually know too much about webdav. 😅 I just made this to do a very simple thing some time ago.

If you'd like it to do more, I'm happy to work on this to fulfill the requirements of sufficiently-tiered sponsors! Or anyone else is welcome to pick up development for advanced features/functionality.

All I know about our particular implementation is from the library godocs that we use: https://pkg.go.dev/golang.org/x/net/webdav

It does look like there is an in-memory implementation of a lock system: https://pkg.go.dev/golang.org/x/net/webdav#NewMemLS

@mholt mholt added the enhancement New feature or request label Aug 17, 2023
@arichiardi
Copy link
Author

Ah wait a sec that is already pretty comprehensive!

It even passes (I guess) the litmus test according to this.

That's a relief and I guess I can actually close this issue, apologise for the noise and thank you for the links!

@arichiardi
Copy link
Author

Just out of curiosity, are you planning to backport this fix upstream?

I wonder why the lib differs there...

@mholt
Copy link
Owner

mholt commented Aug 17, 2023

That was contributed by @mcieno -- I'm not sure I know enough about that either 😅

Glad that page answered your question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants