Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error being logged for every request #4

Merged
merged 1 commit into from
May 23, 2020
Merged

Fix error being logged for every request #4

merged 1 commit into from
May 23, 2020

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented May 23, 2020 •
edited
Loading

According to golang.org/x/net/webdav.Handler, the logger is called for every request, regardless of if err is nil or not.

This fixes error messages being logged for every WebDAV request.

@pgaskin pgaskin changed the title Fixed error being logged for every request Fix error being logged for every request May 23, 2020
mholt
mholt approved these changes May 23, 2020
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks -- this appears to be better.

@mholt mholt merged commit bc5d199 into mholt:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pgaskin @mholt