redirect: determine the FromScheme at runtime (#1297) #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tw <tw19881113@gmail.com>
mholt
reviewed
Feb 9, 2017
| if cfg.TLS.Enabled { | ||
| return "https" | ||
| } | ||
| return "http" |
There was a problem hiding this comment.
Is this thread-safe?
(If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)
There was a problem hiding this comment.
cfg.TLS.Enabled is setup at the server's initialization. Unless we changed it on the fly later, it is thread-safe IMO.
mholt
approved these changes
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfg.TLS.Enabledmay be changed after plugin setup (here), but redirect plugin doesn't catch it.