-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link to sourcegraph in README #2285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
cgatrell
pushed a commit
to cgatrell/caddy
that referenced
this pull request
Oct 18, 2018
ekleiner
pushed a commit
to ekleiner/caddy
that referenced
this pull request
Oct 22, 2018
mholt
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Add callback OnRestartFailed to caddy.Controller * markdown: Fix 500 error (#2266) * Addressed the comments * Update paths for filebrowser plugins * httpserver: update minify ordering (#2273) * Bump required version of golang to 1.10 in README.md (#2267) Adding TLS client cert placeholders #2217 uses features of go v1.10. Update README requirements accordingly. * Update CI to use Go 1.11 * caddytls: gofmt (Go 1.11) (#2241) * Ensure assets path exists before writing UUID file * Adding {when_unix_ms} requests placeholder (unix timestamp with a milliseconds precision) (#2260) * update to quic-go v0.10.0 (#2288) quic-go now vendors all of its dependencies, so we don't need to vendor them here. Created by running: gvt delete github.com/lucas-clemente/quic-go gvt delete github.com/bifurcation/mint gvt delete github.com/lucas-clemente/aes12 gvt delete github.com/lucas-clemente/fnv128a gvt delete github.com/lucas-clemente/quic-go-certificates gvt delete github.com/aead/chacha20 gvt delete github.com/hashicorp/golang-lru gvt fetch -tag v0.10.0-no-integrationtests github.com/lucas-clemente/quic-go * fastcgi: Add default timeouts (#2265) Default fastcgi timeout is 60 seconds Add tests * Fix AppVeyor builds (#2289) * Attempting to fix AppVeyor builds * Trying again, 2015 image this time * Use Appveyor's Go 1.11 stack * Restore GOPATH\bin to PATH and delete old image config * Add gcc to path manually * Addressed the comments * Fix broken link to sourcegraph in README (#2285) * Fix deadlock, ensure instances mutex unlocked (#2296) it's a stupid mistake * proxy: Use DualStack=true in defaultDialer (#2305) * ci: get golint tool from `golang.org/x/lint/golint` (#2324) * templates: TLSVersion (#2323) * new template action: TLS protocol version * new template action: use caddytls.GetSupportedProtocolName Avoids code duplication by reusing existing method to get TLS protocol version used on connection. Also adds tests * Don't return error on onRestartFail. Only log it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this change do, exactly?
Fixes a broken link.
2. Please link to the relevant issues.
N/A
3. Which documentation changes (if any) need to be made because of this PR?
N/A
4. Checklist