Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multi-line curl command #39

Closed
wants to merge 1 commit into from

Conversation

doggy8088
Copy link

@doggy8088 doggy8088 commented Nov 4, 2020

Fixes #36

@doggy8088
Copy link
Author

@mholt Can you take a look on my PR? Thanks

@mholt
Copy link
Owner

mholt commented Nov 4, 2020

What is the problem exactly?

@doggy8088
Copy link
Author

@mholt There are some curl commands like this, which is multi-line command. Your current version can't handle multiline well. I fixed it.

curl -X POST https://api.easypost.com/v2/shipments \
     -u API_KEY: \
     -d 'shipment[to_address][id]=adr_HrBKVA85' \
     -d 'shipment[from_address][id]=adr_VtuTOj7o' \
     -d 'shipment[parcel][id]=prcl_WDv2VzHp' \
     -d 'shipment[is_return]=true' \
     -d 'shipment[customs_info][id]=cstinfo_bl5sE20Y'

@doggy8088 doggy8088 changed the title Fixes https://github.com/mholt/curl-to-go/issues/36 Handle multi-line curl command Nov 4, 2020
@bakert
Copy link
Contributor

bakert commented Nov 22, 2020

I had a dig into what was going on here and added my notes to #36.

@mholt
Copy link
Owner

mholt commented Nov 23, 2020

Is this fixed in #41 then @bakert ?

@bakert
Copy link
Contributor

bakert commented Nov 23, 2020

Is this fixed in #41 then @bakert ?

Yes!

@mholt
Copy link
Owner

mholt commented Nov 23, 2020

Great, thanks so much

@mholt mholt closed this Nov 23, 2020
@doggy8088
Copy link
Author

@mholt Would you please push the latest version to https://mholt.github.io/curl-to-go/ ?

@mholt
Copy link
Owner

mholt commented Nov 24, 2020

It should deploy automatically, this is the gh-pages branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: newlines not working
3 participants