Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float fix #120

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Float fix #120

merged 3 commits into from
Oct 27, 2022

Conversation

apxamccallum
Copy link
Contributor

Addresses #98
Added several tests for floats,
Modified regex hack to check for arrays and to check if number is negative.

mholt
mholt approved these changes Oct 27, 2022
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a great patch! :D

@mholt mholt merged commit e9233d6 into mholt:master Oct 27, 2022
@apxamccallum apxamccallum deleted the float-fix branch October 27, 2022 17:32
nkmr-jp added a commit to nkmr-jp/api-to-go that referenced this pull request Oct 28, 2022
@nkmr-jp
⬆️ Update json-to-go
4c0cf8a 
refs: mholt/json-to-go#120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apxamccallum @mholt