Data source: smsbackuprestore - still WIP #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "smsbackuprestore" data source (see issue #42). This adds SMS text and MMS messages to the timeline.
This PR works, but is not quite complete because not all participants in group messages are added to the timeline in relation to specific MMS. In other words, participants in a group text will not be associated with the text unless they were the sender or receiver (other recipients will not be added to the timeline).
This limitation is a little tricky since I don't yet know how to draw
item<-->personrelationships when building an item graph, since person IDs are hidden away from the data sources (they are arbitrarily created when inserting into the DB, whereas item IDs are known to the data source). Put another way, the only kinds of relations that can currently be created by data sources isitem<-->item.When finished, closes #42.