Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary support for adding favorites in Google Photos. #63

Closed
wants to merge 2 commits into from

Conversation

tripleo1
Copy link

@tripleo1 tripleo1 commented Sep 10, 2020

Please comment on this code.

Tho it doesn't work, it gives me a HTTP 500 INTERNAL SERVER error.

How do I see exactly what HTTP is getting sent upstream?

Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this approach is good, since "favorites" are not a general concept across all data sources; it's Google Photos-specific. Instead, all (or mostly all) of the changes should be within the googlephotos package specifically. I haven't looked at this code in a while and I'm short on time right now but that's definitely more likely to be accepted. :)

To see the HTTP requests that are getting sent, you can do fmt.Printf("%#v", req) in the right place in the code where the request is made. See the googlephotos package.

Thanks for working on this!

@mholt
Copy link
Owner

mholt commented Dec 4, 2020

Closing due to inactivity; needs to take a new approach as well.

@mholt mholt closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants