New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for numpy 1.22 #366
Conversation
numba 0.55.2 supports numpy 1.22, so no reason to stay with numpy 1.21. numpy 1.22 fixes a few known security issues (CVE-2021-41496, CVE-2021-41495)
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 42 42
Lines 5230 5230
=======================================
Hits 5058 5058
Misses 172 172 Continue to review full report at Codecov.
|
@iyanmv I like this thanks! I was just checking today to see about when Numba / NumPy might support Python 3.11 (I see people trying to install Do you think it's worth a published release allowing users to get the latest everything? I don't have any another releases in the queue at this moment. So maybe it could be a small-ish release. |
I also want to check that NumPy 1.22 doesn't throw any deprecation warnings or something similar. I've had that happen before. I'm testing on my machine now. Also curious if the test results have any warnings listed. |
When I ran the tests on my machine I get these warnings (which I've seen before). They seem to be scipy-related. I don't believe NumPy 1.22 added anything. And neither did I see anything when running through some example in IPython. This looks good to go to me. Any other thoughts? Thoughts on publishing a new release now?
|
I guess it's fine to have a small release, but it's your call 😉 Interesting... I only got one warning, but nothing related with numpy or scipy.
I will run them again in a Arch chroot instead of a python env. |
I'm ready to merge. Let me know when you are. |
All tests passed on my chroot. I think numpy 1.22 doesn't break anything. |
Solves #365