Skip to content

Commit

Permalink
Merge 664217e into be4d433
Browse files Browse the repository at this point in the history
  • Loading branch information
mhujer committed Nov 24, 2019
2 parents be4d433 + 664217e commit fcd695d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/EventListener/JsErrorToAlertListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;

class JsErrorToAlertListener implements EventSubscriberInterface
{

public function onKernelResponse(FilterResponseEvent $event): void
public function onKernelResponse(ResponseEvent $event): void
{
$response = $event->getResponse();
$request = $event->getRequest();
Expand Down
20 changes: 10 additions & 10 deletions tests/EventListener/JsErrorToAlertListenerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\StreamedResponse;
use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\HttpKernel\KernelEvents;
Expand Down Expand Up @@ -52,7 +52,7 @@ public function testScriptIsInjected(string $responseBody, string $expectedRespo
{
$response = new Response($responseBody);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand Down Expand Up @@ -108,7 +108,7 @@ public function testScriptIsNotInjectedOnRedirection(int $statusCode): void
{
$response = new Response(self::BASIC_HTML, $statusCode);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand Down Expand Up @@ -139,7 +139,7 @@ public function testScriptIsNotInjectedToStreamedResponse(): void
{
$response = new StreamedResponse();

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -156,7 +156,7 @@ public function testScriptIsNotInjectedOnSubRequest(): void
{
$response = new Response(self::BASIC_HTML);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::SUB_REQUEST,
Expand All @@ -176,7 +176,7 @@ public function testScriptIsNotInjectedOnIncompleteHtmlResponses(): void
{
$response = new Response('<div>Some content</div>');

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -196,7 +196,7 @@ public function testScriptIsNotInjectedOnXmlHttpRequests(): void
{
$response = new Response(self::BASIC_HTML);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(true),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -216,7 +216,7 @@ public function testScriptIsNotInjectedOnNonHtmlRequests(): void
{
$response = new Response(self::BASIC_HTML);

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(false, 'json'),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -237,7 +237,7 @@ public function testScriptIsNotInjectedOnContentDispositionAttachment(): void
$response = new Response(self::BASIC_HTML);
$response->headers->set('Content-Disposition', 'attachment; filename=test.html');

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand All @@ -258,7 +258,7 @@ public function testScriptIsNotInjectedOnNonHtmlContentType(): void
$response = new Response(self::BASIC_HTML);
$response->headers->set('Content-Type', 'text/xml');

$event = new FilterResponseEvent(
$event = new ResponseEvent(
$this->getKernelMock(),
$this->getRequestMock(),
HttpKernelInterface::MASTER_REQUEST,
Expand Down

0 comments on commit fcd695d

Please sign in to comment.