Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated client CA cert #31

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

feldsam
Copy link
Contributor

@feldsam feldsam commented Jun 5, 2024

Hi, on some systems I was getting error

Code:0 Message:cURL error 60: Peer's certificate issuer has been marked as not trusted by the user. (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://fioapi.fio.cz/v1/rest/

and I figured out, that shipped certificate have to be updated

@mhujer
Copy link
Owner

mhujer commented Jun 5, 2024

@feldsam Hi, thanks for the PR! I'm not sure that including the certificate in the repo still makes sense. Maybe it would be better if it depended on composer/ca-bundle directly? What do you think?

//cc @soukicz ?

@feldsam
Copy link
Contributor Author

feldsam commented Jun 5, 2024

There is actually dep on \Kdyby\CurlCaBundle\CertificateHelper, but there is also fallback, if this is not installed. So I just updated fallback cert.

But, it makes sense move suggest dep to required dep and drop fallback

@soukicz
Copy link
Contributor

soukicz commented Jun 5, 2024

I'm not sure that including the certificate in the repo still makes sense

It is nice that it can run without dependencies. And it is just fallback because it is already using composer/ca-bundle if it is available.

@feldsam
Copy link
Contributor Author

feldsam commented Jun 5, 2024

There is still guzzlehttp/guzzle dep and I think, that it is better to use ca-bundle instead of maintaining cert in repo as @mhujer pointed.

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
@feldsam
Copy link
Contributor Author

feldsam commented Jun 5, 2024

So I updated my commit to remove fallback and cert from repo and refactored code to use ca-bundle only

@mhujer mhujer merged commit e5ccd10 into mhujer:master Jun 7, 2024
9 checks passed
@mhujer
Copy link
Owner

mhujer commented Jun 7, 2024

@feldsam thanks! merged and tagged as 5.0.0

@feldsam feldsam deleted the feldsam/update-ca-cert branch June 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants