Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to memorize "ignore date" option #145

Closed
ffxsam opened this issue Jul 26, 2019 · 3 comments
Closed

Ability to memorize "ignore date" option #145

ffxsam opened this issue Jul 26, 2019 · 3 comments
Assignees
Labels
feature request Feature request
Projects
Milestone

Comments

@ffxsam
Copy link

ffxsam commented Jul 26, 2019

Describe the feature that you'd like

It would be nice if the extension remembered our last choice for "Ignore Date". Every time I rebase, I have to uncheck it.

Additional context (optional)

image

@ffxsam ffxsam added the feature request Feature request label Jul 26, 2019
@mhutchie
Copy link
Owner

mhutchie commented Jul 26, 2019

Thanks for making this suggestion, this would definitely be nice to have.

This is actually quite easy to implement, however some thought needs to go into if (all / which subset) of dialog checkboxes should remember the users last choice. I think it would be confusing / mistake prone if only this one dialog checkbox is remembered, as I think it would be a natural assumption for users that if one is remembered, then they all are. However, I think some dialog checkboxes shouldn’t be remembered (e.g. force delete for branches).

An alternative would be to have an extension setting allowing the user to set the default checked / unchecked state of this dialog checkbox. This could easily be extended to other dialogs where there are default values, without any chance of confusing the user.

What are your thoughts on this?

@mhutchie mhutchie added this to the v1.13.0 milestone Jul 27, 2019
@mhutchie mhutchie added this to To Do in Git Graph Jul 27, 2019
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Jul 28, 2019
mhutchie added a commit that referenced this issue Jul 28, 2019
…ing a tag, creating a branch, or rebasing.
@mhutchie mhutchie moved this from In Progress to Ready For Release in Git Graph Jul 28, 2019
@mhutchie
Copy link
Owner

There are now four new extension settings to set the default options on the following dialogs:

  • Add Tag
  • Create Branch
  • Rebase

This will be available in v1.13.0.

If you'd like to use it before the next release, you can download v1.13.0-beta.0, and install it following the instructions provided here.

@ffxsam
Copy link
Author

ffxsam commented Jul 28, 2019

@mhutchie Hey Michael, sorry I didn't get back to you! Having them as settings makes sense, I think. Looking forward to the update!

mhutchie added a commit that referenced this issue Jul 30, 2019
…rge dialogs. Refactoring and code improvement of merge and rebase actions.
@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants