Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show root foler name, not opened folder name in "repo" droplist #158

Closed
thesoftwarejedi opened this issue Aug 12, 2019 · 2 comments
Closed
Assignees
Labels
improvement An improvement to existing functionality
Projects
Milestone

Comments

@thesoftwarejedi
Copy link

Describe the improvement that you'd like
Currently the "repo" drop list shows each directory name of the folder that is opened in the project. If subfolders of the root are the folders opened, the names of these folders are shown instead of the folder name of the root of the repo.

Additional context (optional)

  • I have 2 repos: "SharedTerraform" and "SharedPolicies", and each has a folder named "MyProject"
  • I open SharedTerraform/MyProject and SharedPolicies/MyProject in VSCode resulting in 2 open folders in explorer named the same "MyProject" and "MyProject".
  • Similarly in the git graph, it uses these identical names as the repo name instead of the root repo folder name.

Currently, "repo" is not the repo, but the name of the folder within the repo.

@thesoftwarejedi thesoftwarejedi added the improvement An improvement to existing functionality label Aug 12, 2019
@mhutchie
Copy link
Owner

Thanks for raising this request! The current behaviour is definitely not ideal in your specific project / directory layout.

Currently, when the extension scans the workspace for repositories, the path it stores for the repo is not necessarily the root of the repository, it stores the highest level directory in your workspace that is within the repo. This was done to work around some limitations of the VSCode API.

I’ve come up with an alternative solution that will work for the project / directory layout you have, while still working within the limitations of the VSCode API. This would allow the extension to use the root directories of the repo, meaning that the repos shown for you are the actual repos "SharedTerraform" and "SharedPolicies".

@mhutchie mhutchie added this to the v1.13.0 milestone Aug 12, 2019
@mhutchie mhutchie added this to To Do in Git Graph Aug 12, 2019
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Aug 12, 2019
mhutchie added a commit that referenced this issue Aug 14, 2019
@mhutchie mhutchie moved this from In Progress to Ready For Release in Git Graph Aug 14, 2019
@mhutchie
Copy link
Owner

This will be available in v1.13.0, which will be released in the next day. I took this opportunity to overhaul repository management to better deal with a variety of edge case project structures.

@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An improvement to existing functionality
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants