Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch name display error #160

Closed
HeavenSky opened this issue Aug 15, 2019 · 2 comments
Closed

branch name display error #160

HeavenSky opened this issue Aug 15, 2019 · 2 comments
Assignees
@mhutchie
Labels
bug Something isn't working
Projects
Git Graph
Milestone
v1.13.0

Comments

@HeavenSky
Copy link

Describe the bug
A clear and concise description of what the bug is.
image

Expected behaviour
no shell color code

Environment

  • OS: MAC 10.14.6
  • Visual Studio Code Version:
    version: 1.38.0-insider
    commit : 8985ff7c9d38bd2ce7d1e6b58e40d27c5bbdb67b
    date: 2019-08-15T07:34:22.748Z
    Electron: 4.2.9
    Chrome: 69.0.3497.128
    Node.js: 10.11.0
    V8: 6.9.427.31-electron.0
    OS: Darwin x64 18.7.0

Screenshots (optional)
Add any screenshots to help explain your problem.

Additional context (optional)
Add any other context about the problem here.
@HeavenSky HeavenSky added the bug Something isn't working label Aug 15, 2019
@mhutchie
Copy link
Owner

Thanks for reporting this issue.

  1. What version of the extension are you using?
  2. What configuration have you done to have shell color codes in branch names (please provide steps)? None of the 85,000+ extension users have reported this, and I can't replicate it either.

@mhutchie mhutchie added the needs more info More information has been requested label Aug 15, 2019
mhutchie added a commit that referenced this issue Aug 15, 2019
@mhutchie
#160 Fixed: Shell color codes were included in branch names when the …
03b6db6 
…user overrides Git Config "color.branch" to "always".
@mhutchie mhutchie removed the needs more info More information has been requested label Aug 15, 2019
@mhutchie mhutchie added this to the v1.13.0 milestone Aug 15, 2019
@mhutchie mhutchie added this to To Do in Git Graph Aug 15, 2019
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Aug 15, 2019
@mhutchie mhutchie moved this from In Progress to Ready For Release in Git Graph Aug 15, 2019
@mhutchie
Copy link
Owner

I found that setting the git config color.branch to always (instead of its default value auto) caused this issue to occur.

This has been fixed, and will be released in v1.13.0 (which will be released within a few hours).

@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhutchie mhutchie

Labels
bug Something isn't working
Projects
Git Graph
Released
Milestone
v1.13.0
Development

No branches or pull requests
2 participants
@mhutchie @HeavenSky