Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Visual Studio Code automatically requesting package.json files from Git Graph in the background #172

Closed
mhutchie opened this issue Sep 5, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@mhutchie
Copy link
Owner

mhutchie commented Sep 5, 2019

Describe the Bug
Visual Studio Code requests package.json files when README.md files are requested through Visual Studio Code (here and here). Git Graph currently displays a Visual Studio Code Error Message (Notification) if Visual Studio Code attempts to request a package.json file that doesn't exist.

Steps to Reproduce
Steps to reproduce the behaviour:

  1. Open a repository with a README.md file, but no package.json file in the same folder.
  2. In the Commit Details View, view a diff of the README.md file.
  3. The Error Message (Notification) shown in the attached screenshot appears.

Expected Behaviour
Prevent Visual Studio Code from requesting package.json files.

Environment

  • Git Graph Extension Version: >= 1.3.0
  • Visual Studio Code Version: All with extension-editing
  • Operating System: All

Screenshots (optional)
image

@mhutchie mhutchie added the bug Something isn't working label Sep 5, 2019
@mhutchie mhutchie added this to the v1.15.0 milestone Sep 5, 2019
@mhutchie mhutchie self-assigned this Sep 5, 2019
@mhutchie mhutchie added this to To Do in Git Graph via automation Sep 5, 2019
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Sep 5, 2019
mhutchie added a commit that referenced this issue Sep 5, 2019
@mhutchie
Copy link
Owner Author

mhutchie commented Sep 5, 2019

This will be available in v1.15.0.

If you'd like to use it before the next release, you can download v1.15.0-beta.0, and install it following the instructions provided here.

@mhutchie mhutchie closed this as completed Sep 5, 2019
Git Graph automation moved this from In Progress to Ready For Release Sep 5, 2019
@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Git Graph
Released
Development

No branches or pull requests

1 participant