Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ISO Dates #185

Closed
Gurran opened this issue Sep 25, 2019 · 4 comments
Closed

Add support for ISO Dates #185

Gurran opened this issue Sep 25, 2019 · 4 comments
Assignees
Labels
feature request Feature request nice to have A feature request that is nice to have (lower priority)
Projects
Milestone

Comments

@Gurran
Copy link

Gurran commented Sep 25, 2019

Describe the feature that you'd like
I'd like to be able to see the dates in ISO 8601 fromat.

Additional context (optional)
Git already supports this with git log --date=iso.

@Gurran Gurran added the feature request Feature request label Sep 25, 2019
@Gurran Gurran changed the title Add support fror ISO Dates Add support for ISO Dates Sep 25, 2019
@mhutchie
Copy link
Owner

Thanks for raising this feature request, this would definitely be a nice addition to Git Graph!

Dates and times appear in three places in Git Graph:

  • Date Column (an ideally short date & time value to minimise the volume of text in the table) [e.g. 25 Sep 2019 17:30]
  • Commit Details View (full date & time value) [e.g. Wed Sep 25 2019 17:30:13 GMT+1000]
  • Annotated Tag Details (full date & time value) [same as Commit Details View]

What would you suggest for the short an long formats under ISO 8601? How about:

  • Short format: yyyy-mm-dd hh:mm -> 2019-09-25 17:30
  • Long format: yyyy-mm-dd hh:mm:ss +|-hhmm -> 2019-09-25 17:30:13 +1000

@mhutchie mhutchie added the nice to have A feature request that is nice to have (lower priority) label Sep 25, 2019
@mhutchie mhutchie added this to To Do in Git Graph via automation Sep 25, 2019
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Sep 26, 2019
@mhutchie mhutchie added this to the v1.17.0 milestone Sep 26, 2019
@Gurran
Copy link
Author

Gurran commented Sep 26, 2019

Long format:
To make it as simple as possible. I suggest same long date format that git uses.
yyyy-mm-dd hh:mm:ss +|-hhmm -> 2019-09-26 10:48:59 +0200

Short format:
I think your suggestion looks really good.
yyyy-mm-dd hh:mm -> 2019-09-25 17:30

mhutchie added a commit that referenced this issue Sep 27, 2019
…te Only", to the Extension Setting git-graph.dateFormat.
@mhutchie
Copy link
Owner

This will be available in v1.17.0.

If you'd like to use it before the next release, you can download v1.17.0-beta.1, and install it following the instructions provided here.

Git Graph automation moved this from In Progress to Ready For Release Sep 27, 2019
@Gurran
Copy link
Author

Gurran commented Sep 27, 2019

Thank you so much for including this change. It really means a lot to me! 😃

@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request nice to have A feature request that is nice to have (lower priority)
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants