New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make committer identity more apparent #26
Comments
Thanks for the suggestion. This is a great idea! |
Hey there. Found this extension just today and really love it. Wanted to try my hand at coding this in, but dunno if I should, since Node and TS is quite foreign to me at the moment... 😟 |
@meierw Thanks for the feedback & the offer. There are three parts to this feature:
Perhaps you could have a go at the first point if you're interested, as you can work on it in your own files without needing to integrate with the extension, and it also requires the least background in Node.js or Typescript. Once you have it working for one of the api's I can help bring it into the extension. |
Alright. Will definitely try to build the first part. Can't give you any estimates on it being finished, since I'll have to invest time in learning Node and TS coding quirks. |
@meierw That's awesome, thank you! This issue isn't high on my priority list, so there's no timeline it needs to be completed by. Feel free to send me an email if you have any questions. |
Hi @mhutchie, Would like to share some of the analysis I was working on weeks ago on your first point:
So, Gravatar uses MD5 hash of the lowercased email to get the image or set a default if the user does not exists or does not have one.
The URL I most use will be this one, for a 100px image size and a 'Retro' style as defined here
Looking forward to collaborate in this project, |
@felipeandres254 That's great! For GitHub, I believe you can get images in the following way https://github.com/tecosaur.png?size=40 |
The retrieval method is already built. The code can be found here: master...meierw:feature/commit_avatar The rest is in the works. |
I've finished off the implementation based on @meierw's great work for integration with GitHub, GitLab & Gravatar. I'll be using & monitoring it this next week to make sure there aren't any issues, as the caching, request queuing & api rate limiting mechanisms have a significant amount of time dependant logic. This feature should be released within 1-2 weeks. |
This will be available in v1.4.5, which I intend to release in the next two days. If you'd like to use it before the next release, you can download v1.4.5-beta.1, and install it following the instructions provided here. |
Fantastic! One quick question — does this show icons when there's only one commiter? (such as happens in personal git repos) because in those cases —taking a minimalistic approach— the profile icon is then unnecessary visual clutter. |
Currently it will show avatars when there's only one committer. I think most people would think it was a bug if they have fetch avatars turned on, and no avatars showed (even though it makes sense to hide them). If others like the idea of hiding avatars if there is only one committer, I think it would be best to add a setting to enable / disable the additional behaviour. |
I'll cut straight to the chase.
At the moment the 'Author' column doesn't make it easy to see at a glance who did what commit
It not terribly, but I personally can't tell at a glance who's responsible for what.
Feature Request
It would be nice if use of colour/icons to differentiate authors could be applied so that it's possible to tell at a glance who did what.
Ideas
Otherwise this is very nice and easy to use. Great work so far!
tecosaur.
The text was updated successfully, but these errors were encountered: