Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Git Config Include Directives #281

Closed
ghost opened this issue Mar 20, 2020 · 8 comments
Closed

Support Git Config Include Directives #281

ghost opened this issue Mar 20, 2020 · 8 comments
Assignees
Labels
feature request Feature request nice to have A feature request that is nice to have (lower priority)
Projects
Milestone

Comments

@ghost
Copy link

ghost commented Mar 20, 2020

Describe the feature that you'd like
Git Graph does not seem to be recognising the includeIf gitconfig property.

For example:
My current .gitconfig file is:

[user]
	email = main_email_address
	name = user_name
[includeIf "gitdir:/data/dev/WORK/"]
    path = /data/dev/dotfiles/gitconfigwork
[push]
        default = simple
[fetch]
        prune = true

includeIf checks if the path exists on the disk and loads additional configuration if the path is found. In my case /data/dev/dotfiles/gitconfigwork only specifies different email address for my work projects in WORK folder as below:

[user]
	email = work_email_address

I do appreciate I can update details per project manually from Git Graph settings, but it would be nice if Git Graph could read those settings too

@ghost ghost added the feature request Feature request label Mar 20, 2020
@ghost ghost assigned mhutchie Mar 20, 2020
@mhutchie
Copy link
Owner

mhutchie commented Mar 20, 2020

Thanks for raising this feature request! I wasn’t aware of includeIf, so thanks for also providing some background on it.

Git Graph currently uses the commands git config --list --local and git config --list --global to read the local and global config of a repository. I’ll investigate what changes I need to make so the extension can support includeIf, and implement it in an upcoming release.

@mhutchie mhutchie added this to To Do in Git Graph via automation Mar 20, 2020
@ghost
Copy link
Author

ghost commented Mar 20, 2020

Thanks a lot, no rush, your extension is already fantastic. This would make it even better for me ;-)

@mhutchie mhutchie added the nice to have A feature request that is nice to have (lower priority) label Mar 20, 2020
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph Sep 13, 2020
@mhutchie mhutchie added this to the v1.27.0 milestone Sep 13, 2020
@mhutchie mhutchie changed the title .gitconfig includeIf Support Git Config Include Directives Sep 13, 2020
@ghost
Copy link
Author

ghost commented Sep 18, 2020

I can see that you have started implementing this feature, please ping me in if you need any testers.

@mhutchie
Copy link
Owner

Hi @caasi-dev,

I’ll be publishing a beta release for this functionality in the next few hours, which will include this feature. I’ll reply once it is available.

@ghost
Copy link
Author

ghost commented Sep 18, 2020

Thank you !

@mhutchie
Copy link
Owner

This will be available in v1.27.0.

If you'd like to use it before the next release, you can download v1.27.0-beta.0, and install it following the instructions provided here.

Git Graph automation moved this from In Progress to Ready For Release Sep 19, 2020
@ghost
Copy link
Author

ghost commented Sep 19, 2020

I will be installing fresh system tonight, so this will be a perfect time to test this, thank you.

@ghost
Copy link
Author

ghost commented Sep 20, 2020

all repositories identified correctly, thank you for implementing this :-)

@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request nice to have A feature request that is nice to have (lower priority)
Projects
Git Graph
Released
Development

No branches or pull requests

1 participant