Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show changes in working folder #36

Closed
morganlombard opened this issue Mar 18, 2019 · 4 comments
Closed

Add ability to show changes in working folder #36

morganlombard opened this issue Mar 18, 2019 · 4 comments
Assignees
Labels
feature request Feature request
Projects
Milestone

Comments

@morganlombard
Copy link

Describe the feature that you'd like
When clicking on Uncommitted changes, show the diff similarly to when clicking on a commit.
Add the context-menu option to diff with working folder.

@mhutchie
Copy link
Owner

I'm not sure what additional value this would add, for the following reasons:

  • If the Uncommited changes expands to show something similar to the commit details view:
    • There isn't any useful information for the left of the commit details view, so there is no point in showing it.
    • The diff on the right is just like you can see on the Visual Studio Code "Source Control" tab, so it also doesn't add any new functionality from native Visual Studio Code.
  • None of the actions of the commit context menu are applicable to Uncommited changes, without them being commited first.
  • The only action I can think of for the context menu would be to commit the uncommited changes (which is also natively in Visual Studio Code).

To me it seems that making these changes doesn't add any functionality that isn't already available easily in Visual Studio Code, and anything that could be reasonably implemented in Git Graph would only be a subset of what Visual Studio Code already provides. Please let me know your opinion on what you would like to see in Git Graph for Uncommited changes, and why it would be better to be implemented in Git Graph instead of what is already natively available.

@mhutchie
Copy link
Owner

Closing for now, as I don't see the value added to Git Graph by making this change.

@mhutchie
Copy link
Owner

I'm reopening this issue, as it was requested in #29 (which implements comparing any two commits) that it be extended to support comparison with the working folder / uncommitted state. This would allow new functionality to be implemented, that is not already available natively in Visual Studio Code so I think it would now make sense to add support for the working folder / uncommitted state.

@mhutchie mhutchie reopened this May 15, 2019
@mhutchie mhutchie added this to the v1.6.0 milestone May 15, 2019
@mhutchie mhutchie added this to To Do in Git Graph May 15, 2019
@mhutchie mhutchie moved this from To Do to In Progress in Git Graph May 20, 2019
mhutchie added a commit that referenced this issue May 22, 2019
@mhutchie mhutchie moved this from In Progress to Ready For Release in Git Graph May 22, 2019
@mhutchie
Copy link
Owner

This will be available in v1.6.0. I have implemented:

  • View uncommitted changes
  • Comparing any commit with the uncommitted changes
  • Three new Git actions from the new Uncommitted Changes context menu:
    • Reset uncommitted changes to HEAD
    • Clean untracked files
    • Open the Visual Studio Code Source Control View

If you'd like to use it before the next release, you can download v1.6.0-beta.2, and install it following the instructions provided here.

@mhutchie mhutchie moved this from Ready For Release to Released in Git Graph May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Git Graph
Released
Development

No branches or pull requests

2 participants